Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Support hybrid search multiple vector fields #663

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

congqixia
Copy link
Contributor

@congqixia congqixia commented Feb 1, 2024

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 February 1, 2024 10:19
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/L Denotes a PR that changes 100-499 lines. labels Feb 1, 2024
Signed-off-by: Congqi Xia <[email protected]>
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (1e03ea4) 73.41% compared to head (478d87c) 72.03%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
- Coverage   73.41%   72.03%   -1.38%     
==========================================
  Files          47       49       +2     
  Lines        4352     4438      +86     
==========================================
+ Hits         3195     3197       +2     
- Misses       1043     1127      +84     
  Partials      114      114              
Files Coverage Δ
client/client.go 28.94% <ø> (ø)
client/reranker.go 0.00% <0.00%> (ø)
client/data.go 64.77% <7.89%> (-5.96%) ⬇️
client/ann_request.go 0.00% <0.00%> (ø)

@mergify mergify bot added the ci-passed auto merge needed label label Feb 1, 2024
@congqixia
Copy link
Contributor Author

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Feb 1, 2024
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Feb 2, 2024
@sre-ci-robot sre-ci-robot merged commit 43e3bd2 into milvus-io:master Feb 2, 2024
7 checks passed
@congqixia congqixia deleted the support_hybrid_search branch February 20, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants